Adds device_index and bind_device_by_index to android and linux #573
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2025
ningyuan-wang
force-pushed
the
bind_if_index
branch
from
095f013 to
c76a3e4
Compare
|
The PR is updated to fix the failed formatting check. |
ningyuan-wang
force-pushed
the
bind_if_index
branch
from
c76a3e4 to
92e8580
Compare
|
Commit is updated to also include
|
Darksonn
reviewed
May 1, 2025
There was a problem hiding this comment.
Idea: Should we let the v4/v6 methods also exist on Linux and just have them call bind_device_by_index? That way, it's easier to write code that supports both cases.
Thoughts @Thomasdezeeuw ?
This commit adds bind_device_by_index to android, fuchsia, and linux OS. This binds socket to a particular interface similarly to bind_device except that the interfaces are referenced by its index rather than name.
ningyuan-wang
force-pushed
the
bind_if_index
branch
from
92e8580 to
b896177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds device_index and bind_device_by_index to android and linux OS. This allows the sockets to bind to the interface index directly, and checks the interface index bonded to.
libcversion is bumped to `0.2.172' as it is the first version SO_BINDTOIFINDEX is defined for Android.Fixes #569